Skip to content

Remove unused variable #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holtkamp wants to merge 4 commits into
base: 2.18.x
Choose a base branch
from
Open

Remove unused variable #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8326654
Lock file maintenance
renovate[bot] Sep 24, 2022
8d96a91
Remove unused variable
holtkamp Sep 28, 2022
73a2719
Set proper type to MimePart
holtkamp Sep 28, 2022
ffd2496
Use lower casing consistently
holtkamp Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions docs/book/message/attachments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ use Laminas\Mime\Message as MimeMessage;
use Laminas\Mime\Mime;
use Laminas\Mime\Part as MimePart;

$body = new MimeMessage();

$text = new MimePart($textContent);
$text->type = Mime::TYPE_TEXT;
$text->charset = 'utf-8';
Expand All @@ -112,11 +110,14 @@ $html->type = Mime::TYPE_HTML;
$html->charset = 'utf-8';
$html->encoding = Mime::ENCODING_QUOTEDPRINTABLE;

$content = new MimeMessage();
$multipartContent = new MimeMessage();
// This order is important for email clients to properly display the correct version of the content
$content->setParts([$text, $html]);
$multipartContent->setParts([$text, $html]);

$contentPart = new MimePart($content->generateMessage());
$multipartPart = new MimePart($multipartContent->generateMessage());
$multipartPart->charset = 'utf-8';
$multipartPart->type = 'multipart/alternative';
$multipartPart->boundary = $multipartContent->getMime()->boundary();

$image = new MimePart(fopen($pathToImage, 'r'));
$image->type = 'image/jpeg';
Expand All @@ -125,7 +126,7 @@ $image->disposition = Mime::DISPOSITION_ATTACHMENT;
$image->encoding = Mime::ENCODING_BASE64;

$body = new MimeMessage();
$body->setParts([$contentPart, $image]);
$body->setParts([$multipartPart, $image]);

$message = new Message();
$message->setBody($body);
Expand Down