Drop support for PHP 8.1, add support for PHP 8.5 - #73
Merged
Conversation
Upgrades PHPUnit to 11.x Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…decouple tests from service manager lib Signed-off-by: George Steel <george@net-glue.co.uk>
…ailing and also need dependencies installed anyway Signed-off-by: George Steel <george@net-glue.co.uk>
Ocramius
requested changes
Oct 16, 2025
Ocramius
left a comment
Ocramius
left a comment
Member
There was a problem hiding this comment.
I'm quite unconvinced of the reflection based tests introduced here: can we instead check the observable behaviour from an API perspective?
Member
Author
I don't disagree - these are just inlined from the trait shipped by laminas-servicemanager - I was being lazy :) |
Signed-off-by: George Steel <george@net-glue.co.uk>
Member
|
TIL: they are rubbish 🤣 Right, let's ship this, and we'll get breakages on ServiceManager upgrades later on |
Ocramius
approved these changes
Oct 16, 2025
Member
|
Thanks @gsteel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades PHPUnit to 11.x