Remove support for PHP 8.1, add support for PHP 8.5 - #62
Merged
Conversation
Signed-off-by: sandesh.as <cod48668@adobe.com>
sandesh-as
marked this pull request as draft
October 30, 2025 08:17
sandesh-as
marked this pull request as ready for review
October 30, 2025 08:18
sandesh-as
force-pushed
the
Php-8.5-support
branch
from
October 31, 2025 03:36
f00b9ac to
70a4e5e
Compare
gsteel
requested changes
Nov 2, 2025
gsteel
left a comment
gsteel
left a comment
Member
There was a problem hiding this comment.
Thanks @sandesh-as
Please can you make the following changes:
- Disable
MissingOverrideAttributeinpsalm.xmlfor both/srcand/testExample - Disable
ClassMustBeFinalinpsalm.xmlonly for/src - Make all test cases final using the final keyword
- Update
psalm-baseline.xmlwhen you're done.
gsteel
changed the title
Signed-off-by: sandesh.as <cod48668@adobe.com>
Contributor
Author
|
@gsteel Thank you for the suggestions. I’ve made the updates accordingly — could you please review |
Signed-off-by: sandesh-as <cod48668@adobe.com>
gsteel
added
Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description