Skip to content

Deprecate Http Message and Mvc Interfaces/Classes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tyrsson wants to merge 3 commits into
base: 3.21.x
Choose a base branch
from
Draft

Deprecate Http Message and Mvc Interfaces/Classes #127

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcd21e5
Initial changes
tyrsson Sep 11, 2025
0f92c5e
Update baseline for deprecation notices about usage in unit test.
tyrsson Sep 11, 2025
ccfa9cd
Resolve all review comments except Parameters
tyrsson Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@
<code><![CDATA[$value]]></code>
</MixedAssignment>
</file>
<file src="src/DispatchableInterface.php">
<DeprecatedClass>
<code><![CDATA[Response|mixed]]></code>
</DeprecatedClass>
<DeprecatedInterface>
<code><![CDATA[?ResponseInterface]]></code>
<code><![CDATA[RequestInterface]]></code>
</DeprecatedInterface>
</file>
<file src="src/ErrorHandler.php">
<InvalidArgument>
<code><![CDATA[[static::class, 'addError']]]></code>
Expand Down Expand Up @@ -152,6 +161,9 @@
</PossiblyNullOperand>
</file>
<file src="src/Message.php">
<DeprecatedInterface>
<code><![CDATA[Message]]></code>
</DeprecatedInterface>
<DocblockTypeContradiction>
<code><![CDATA[! is_array($spec) && ! $spec instanceof Traversable]]></code>
<code><![CDATA[is_scalar($key)]]></code>
Expand All @@ -177,6 +189,11 @@
<code><![CDATA[setMetadata]]></code>
</MissingReturnType>
</file>
<file src="src/Parameters.php">
<DeprecatedInterface>
<code><![CDATA[Parameters]]></code>
</DeprecatedInterface>
</file>
<file src="src/PriorityList.php">
<FalsableReturnStatement>
<code><![CDATA[$node ? $node['data'] : false]]></code>
Expand All @@ -201,6 +218,24 @@
<code><![CDATA[unserialize]]></code>
</MethodSignatureMustProvideReturnType>
</file>
<file src="src/Request.php">
<DeprecatedClass>
<code><![CDATA[Message]]></code>
</DeprecatedClass>
<DeprecatedInterface>
<code><![CDATA[Request]]></code>
<code><![CDATA[Request]]></code>
</DeprecatedInterface>
</file>
<file src="src/Response.php">
<DeprecatedClass>
<code><![CDATA[Message]]></code>
</DeprecatedClass>
<DeprecatedInterface>
<code><![CDATA[Response]]></code>
<code><![CDATA[Response]]></code>
</DeprecatedInterface>
</file>
<file src="src/SplPriorityQueue.php">
<DocblockTypeContradiction>
<code><![CDATA[is_array($priority)]]></code>
Expand Down Expand Up @@ -322,6 +357,9 @@
</UndefinedInterfaceMethod>
</file>
<file src="test/ArrayUtilsTest.php">
<DeprecatedClass>
<code><![CDATA[new Parameters($array)]]></code>
</DeprecatedClass>
<DeprecatedConstant>
<code><![CDATA[ArrayUtils::ARRAY_FILTER_USE_BOTH]]></code>
<code><![CDATA[ArrayUtils::ARRAY_FILTER_USE_KEY]]></code>
Expand Down Expand Up @@ -381,7 +419,25 @@
<code><![CDATA[assertIsArray]]></code>
</RedundantConditionGivenDocblockType>
</file>
<file src="test/MessageTest.php">
<DeprecatedClass>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
<code><![CDATA[new Message()]]></code>
</DeprecatedClass>
</file>
<file src="test/ParametersTest.php">
<DeprecatedClass>
<code><![CDATA[$parameters]]></code>
<code><![CDATA[new Parameters()]]></code>
<code><![CDATA[new Parameters()]]></code>
<code><![CDATA[new Parameters()]]></code>
<code><![CDATA[new Parameters(['foo' => 'bar'])]]></code>
</DeprecatedClass>
<UndefinedPropertyFetch>
<code><![CDATA[$parameters->bar]]></code>
<code><![CDATA[$parameters->baz]]></code>
Expand Down
3 changes: 3 additions & 0 deletions src/DispatchableInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

namespace Laminas\Stdlib;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0.
*/
Comment thread
tyrsson marked this conversation as resolved.
interface DispatchableInterface
{
/**
Expand Down
6 changes: 6 additions & 0 deletions src/Message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
use function is_scalar;
use function sprintf;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0.
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
class Message implements MessageInterface
{
/** @var array */
Expand Down
6 changes: 6 additions & 0 deletions src/MessageInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

use Traversable;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0. Use Psr\Http\Message\MessageInterface instead
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
interface MessageInterface
{
/**
Expand Down
4 changes: 4 additions & 0 deletions src/Parameters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
use function parse_str;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0.
*
* @see https://github.com/laminas/laminas-diactoros as a possible replacement.
*
Comment thread
tyrsson marked this conversation as resolved.
* @template TKey of array-key
* @template TValue
* @template-extends PhpArrayObject<TKey, TValue>
Expand Down
4 changes: 4 additions & 0 deletions src/ParametersInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
* class QueryParams extends ArrayObject implements Parameters {}
* and have 90% of the functionality
*
* @deprecated since 3.21.0; Will be removed in 4.0.0.
*
* @see https://github.com/laminas/laminas-diactoros as a possible replacement.
*
Comment thread
tyrsson marked this conversation as resolved.
Outdated
* @template TKey
* @template TValue
* @template-extends ArrayAccess<TKey, TValue>
Expand Down
6 changes: 6 additions & 0 deletions src/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

namespace Laminas\Stdlib;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0.
Comment thread
tyrsson marked this conversation as resolved.
Outdated
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
class Request extends Message implements RequestInterface
{
// generic request implementation
Expand Down
6 changes: 6 additions & 0 deletions src/RequestInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

namespace Laminas\Stdlib;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0. Use Psr\Http\Message\RequestInterface instead
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
interface RequestInterface extends MessageInterface
{
}
6 changes: 6 additions & 0 deletions src/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

namespace Laminas\Stdlib;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0.
Comment thread
tyrsson marked this conversation as resolved.
Outdated
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
class Response extends Message implements ResponseInterface
{
// generic response implementation
Expand Down
6 changes: 6 additions & 0 deletions src/ResponseInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@

namespace Laminas\Stdlib;

/**
* @deprecated since 3.21.0; Will be removed in 4.0.0. Use Psr\Http\Message\ResponseInterface instead
*
* @see https://www.php-fig.org/psr/psr-7/
* @see https://github.com/laminas/laminas-diactoros as a possible implementation.
*/
interface ResponseInterface extends MessageInterface
{
}