💚 Fix

Author: falexwolf

nbproject/dev/_jupyter_communicate.py

@@ -122,7 +122,9 @@ def find_nb_path_via_parent_process():
                 potential_path = arg  # Store the last one found
 
         if is_nbconvert_call and "--inplace" not in cmdline:
-            raise ValueError("Please execute 'nbconvert' with option '--inplace'.")
+            raise ValueError(
+                "Please execute notebook 'nbconvert' by passing option '--inplace'."
+            )
 
         if is_nbconvert_call and potential_path:
             # We found something that looks like an nbconvert call and an ipynb file

tests/test_nbconvert.py

@@ -8,11 +8,10 @@ def test_running_via_nbconvert():
         shell=True,
         capture_output=True,
     )
-    print(result.stdout.decode())
-    print(result.stderr.decode())
     assert result.returncode == 1
     assert (
-        "Please execute 'nbconvert' with option '--inplace'." in result.stderr.decode()
+        "Please execute notebook 'nbconvert' by passing option '--inplace'."
+        in result.stderr.decode()
     )
 
     result = subprocess.run(
@@ -22,4 +21,4 @@ def test_running_via_nbconvert():
     )
     print(result.stdout.decode())
     print(result.stderr.decode())
-    assert result.returncode == 1
+    assert result.returncode == 0