Move to the S6 init system#10
Open
brutalgg wants to merge 8 commits intolancachenet:masterfrom
brutalgg:s6-overlay
Open
Move to the S6 init system#10brutalgg wants to merge 8 commits intolancachenet:masterfrom brutalgg:s6-overlay
brutalgg wants to merge 8 commits intolancachenet:masterfrom
brutalgg:s6-overlay
Conversation
Author
|
It appears I missed updating the goss tests for circle CI to pass. I will look into how I might be able to get these running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are to use the S6 init system in place of supervisor. This change drastically reduces the size of the resulting container by not requiring the entire python language to be installed as well as any supervisor dependencies.
Also structure has been added to allow the customization of the UID:GID of the container user. This is more flexible for upstream images as it allows the consumer of an image to define their own UID:GID without reliance on a user existing in the container with the desired id combination.
I've also created sample patches for upstream consumers of this image to demonstrate how s6 might be used. These changes can be viewed in the following repos or by pulling the image directly from dockerhub.