docs: mount lance-flink connector docs into the integrations site - #8987
Open
fightBoxing wants to merge 3 commits into
Open
docs: mount lance-flink connector docs into the integrations site#8987fightBoxing wants to merge 3 commits into
fightBoxing wants to merge 3 commits into
Conversation
Add LANCE_FLINK_REPO to make-full-website.sh so the lance-flink connector docs (docs/src/) are aggregated under integrations/flink, following the existing lance-spark / lance-trino pattern.
github-actions
Bot
added
documentation
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
The flink docs mount added to make-full-website.sh needs the lance-flink repo checked out and LANCE_FLINK_REPO wired into the Assemble step, otherwise the build keeps the placeholder and logs a missing-repo warning.
lance-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
Complete the integration pattern by cleaning the two generated Flink paths (integrations/flink and project-specific/flink.md) so clean / rollback does not retain stale outputs, matching lance-context.
lance-gatekeeper
Bot
removed
the
K-changes
Contributor
There was a problem hiding this comment.
Both prior findings are fixed. The production workflow now supplies the Flink checkout, the assembled site builds against lance-flink#75, and cleanup removes both generated outputs.
The related docs PR is still open, and the Lance deploy runs only when changes are pushed to its main branch. If this PR merges first, Flink remains a placeholder until #75 lands and a later Lance deployment runs; merging #75 first or arranging a subsequent Lance docs deploy avoids that delay.
lance-gatekeeper
Bot
added
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
LANCE_FLINK_REPOtodocs/make-full-website.shso the lance-flink connector docs (docs/src/) are aggregated underintegrations/flink, following the existinglance-spark/lance-trino/lance-contextpattern.Changes
LANCE_FLINK_REPOenv var (default$HOME/oss/lance-flink), documented in the usage block.flink_repoviaresolve_repo_dir.flink_repo/docs/src→docs_src/integrations/flinkand appendApache Flink: flinkto the integrations nav.flink_repo/CONTRIBUTING.md→community/project-specific/flink.md.Note
The corresponding
docs/src/content lives in the lance-flink repository and is not part of this PR. The flink docs are still in progress; until the lance-flinkdocs/src/is merged, the build keeps the placeholder and logs a warning (same behaviour as other missing repos).Related: lance-format/lance-flink#63