Skip to content

Fix: Improve requests session mounting and type hint clarity in tools.py #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mirza-Samad-Ahmed-Baig wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix: Improve requests session mounting and type hint clarity in tools.py #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vision_agent/utils/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from pydantic import BaseModel
from requests import Session
from requests.adapters import HTTPAdapter
from urllib.parse import urlparse
from urllib3.util.retry import Retry

from vision_agent.utils.exceptions import RemoteToolCallFailed
Expand Down Expand Up @@ -128,7 +129,7 @@ def _create_requests_session(
504, # Gateway Timeout
],
)
session.mount(url, HTTPAdapter(max_retries=retries if num_retry > 0 else 0))
session.mount(urlparse(url).scheme, HTTPAdapter(max_retries=retries if num_retry > 0 else 0))
session.headers.update(headers)
return session

Expand All @@ -137,7 +138,7 @@ def _call_post(
url: str,
payload: dict[str, Any],
session: Session,
files: Optional[List[Tuple[Any, ...]]] = None,
files: Optional[List[Tuple[str, bytes]]] = None,
function_name: str = "unknown",
is_form: bool = False,
) -> Any:
Expand Down
Loading