feat: promote npm edge tag to latest when prerelease is promoted - #76
Merged
Conversation
Adds a 'released' trigger to the release workflow with a lightweight 'promote' job that runs npm dist-tag to move 'latest' to the current version when a prerelease is promoted to a full release. The existing publish pipeline remains gated to 'published' events only.
❌ Deploy Preview for lando-go failed. Why did it fail? →
|
| echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION (was edge-only)" | ||
| env: | ||
| TAG_NAME: ${{ github.event.release.tag_name }} | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_DEPLOY_TOKEN}} |
There was a problem hiding this comment.
Race condition: promote job fails on fresh non-prerelease
Medium Severity
When a non-prerelease is published directly, GitHub fires both published and released events, creating two independent workflow runs. The promote job (~15s) will almost certainly execute npm dist-tag add before the deploy job (~minutes of install/lint/test/publish) finishes npm publish. Since the version doesn't exist on npm yet, dist-tag add fails. The PR description claims this scenario is "harmless" and "idempotent," but npm dist-tag add on a nonexistent version is an error, not a no-op. This causes a red ✗ on every fresh non-prerelease publish, creating noise and masking real failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Problem
When a release is published as a prerelease, it gets tagged as
edgeon npm. Later, when the release is promoted to a full release in GitHub, the npmlatesttag doesn't update because the workflow only triggered onpublished.Solution
releasedto the release workflow trigger typespromotejob that only runsnpm dist-tag add latest— no install, no lint, no tests, no re-publishreleasedevent (when a prerelease is promoted to full release)deployjob is now explicitly gated topublishedevents only (no behavior change)TAG_NAMEenv var instead of direct interpolation to prevent script injectionFlow
edgetag (unchanged)promotejob runs, pointslatestto that version (~15s)The
dist-tag addcommand is idempotent, so if bothpublishedandreleasedfire on a fresh non-prerelease publish, the redundant promote is harmless.Note
Low Risk
CI-only change limited to npm dist-tag updates on a new release event; main risk is incorrect tagging if the tag/version parsing is wrong or credentials are misconfigured.
Overview
Extends the
Publish to NPMGitHub Actions workflow to also trigger onrelease.releasedevents.Adds a new
promotejob that runs only onreleasedto set the npmlatestdist-tag to the promoted version (derived from the GitHub tag) without reinstalling deps, running tests, or republishing.Explicitly gates the existing
deploypublish job torelease.publishedevents to avoid running the full pipeline on promotion events.Written by Cursor Bugbot for commit 3edee88. This will update automatically on new commits. Configure here.