feat: promote npm edge tag to latest when prerelease is promoted#70
Merged
Conversation
Adds a 'released' trigger to the release workflow with a lightweight 'promote' job that runs npm dist-tag to move 'latest' to the current version when a prerelease is promoted to a full release. The existing publish pipeline remains gated to 'published' events only.
✅ Deploy Preview for lando-joomla ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION (was edge-only)" | ||
| env: | ||
| TAG_NAME: ${{ github.event.release.tag_name }} | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_DEPLOY_TOKEN}} |
There was a problem hiding this comment.
Race condition: promote fails before deploy publishes package
Medium Severity
When a non-prerelease is published directly (not promoted from prerelease), GitHub fires both published and released events simultaneously. The promote job (~15s) will reach npm dist-tag add long before deploy finishes its full install/lint/test/publish pipeline. Since the version doesn't exist on npm yet, npm dist-tag add will fail. The PR description claims this redundant promote is "harmless," but the race condition causes a guaranteed workflow failure for every direct non-prerelease publish.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
When a release is published as a prerelease, it gets tagged as
edgeon npm. Later, when the release is promoted to a full release in GitHub, the npmlatesttag doesn't update because the workflow only triggered onpublished.Solution
releasedto the release workflow trigger typespromotejob that only runsnpm dist-tag add latest— no install, no lint, no tests, no re-publishreleasedevent (when a prerelease is promoted to full release)deployjob is now explicitly gated topublishedevents only (no behavior change)TAG_NAMEenv var instead of direct interpolation to prevent script injectionFlow
edgetag (unchanged)promotejob runs, pointslatestto that version (~15s)The
dist-tag addcommand is idempotent, so if bothpublishedandreleasedfire on a fresh non-prerelease publish, the redundant promote is harmless.Note
Low Risk
Workflow-only change affecting npm dist-tag management; risk is limited to potentially mis-tagging
latestif the release tag/version is incorrect or the token permissions are misconfigured.Overview
Updates the release workflow to also trigger on GitHub
release.releasedevents and adds a newpromotejob that runsnpm dist-tag add ... latestbased on the release tag, allowing prereleases previously published underedgeto be promoted tolatestwithout re-publishing.The existing
deploypublish pipeline is now explicitly gated to only run onrelease.published, reducing the chance of duplicate publish runs when a release is later promoted.Written by Cursor Bugbot for commit c5d59ca. This will update automatically on new commits. Configure here.