Skip to content

Repair shell detection and complete core parser and finder coverage - #76

Merged
pirog merged 2 commits into
mainfrom
issue-5263828142-70f303eebe
Aug 27, 2026
Merged

Repair shell detection and complete core parser and finder coverage#76
pirog merged 2 commits into
mainfrom
issue-5263828142-70f303eebe

Conversation

@emoriwan

Copy link
Copy Markdown
Collaborator

Closes #75

@pirog

pirog commented Aug 27, 2026

Copy link
Copy Markdown
Member

@emoriwan can you tell me why the unit tests are failing and propose a fix?

@emoriwan

Copy link
Copy Markdown
Collaborator Author

@pirog

All three OS jobs fail on the same incorrect assertion in test/parse.spec.js:95: it expects eight tests.test entries, but there are seven.

parse() defaults to testHeader: ['Test'], so basic-example.md’s Verifying section correctly lands in tests.invalid; its test is the assumed eighth entry. The other 39 unit tests pass, as do lint and every shell, Leia, and module-format job. The Browserslist warning is unrelated.

Proposed fix: leave parser behavior unchanged. Replace the brittle aggregate count with assertions that commands from both code blocks appear in the test bucket. For maximum isolation, use a tiny fixture containing one Testing section with two code blocks and assert both parsed commands.

@pirog

pirog commented Aug 27, 2026

Copy link
Copy Markdown
Member

@emoriwan ok, can you do that and push up the fix for me to look at pls?

@emoriwan

Copy link
Copy Markdown
Collaborator Author

@pirog

I received your comment, but I couldn't safely publish the detailed response. I've kept it in the linked private session for review.

@pirog
pirog merged commit 1f75b42 into main Aug 27, 2026
12 checks passed
@pirog
pirog deleted the issue-5263828142-70f303eebe branch August 27, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repair shell detection and complete core parser and finder coverage

2 participants