fix: use Get-Content instead of Invoke-WebRequest for PS 5.1 pipeline test - #112
Closed
AaronFeledy wants to merge 1 commit into
Closed
fix: use Get-Content instead of Invoke-WebRequest for PS 5.1 pipeline test#112AaronFeledy wants to merge 1 commit into
AaronFeledy wants to merge 1 commit into
Conversation
… test Invoke-WebRequest with file:// URLs throws NullReferenceException in PowerShell 5.1. Use Get-Content -Raw like the PowerShell 7 test does.
✅ Deploy Preview for get-lando canceled.
|
✅ Deploy Preview for setup-lando ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invoke-WebRequestwithfile://URLs throwingNullReferenceExceptionGet-Content -Rawinstead, matching the PowerShell 7 test approachRoot Cause
Invoke-WebRequestin PowerShell 5.1 does not properly handlefile://protocol URLs, resulting in:Fixes the CI failure seen in PR #111: https://github.com/lando/setup-lando/actions/runs/20683213314/job/59380355221
Note
Updates the Windows workflow to avoid a PS 5.1 failure when invoking a local script via
file://..github/workflows/pr-windows-script-pipeline-tests.yml, replaceInvoke-WebRequest "file://.../setup-lando.ps1" | Invoke-ExpressionwithGet-Content -Raw | Invoke-Expressionfor the PowerShell 5.1 steppwsh) approach; verification (Test-Path,lando version --all) unchangedWritten by Cursor Bugbot for commit 17b7b75. This will update automatically on new commits. Configure here.