Python3 interface class and helper utility added #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Python3 based class for dealing with REGCOIL output. Additionally, a command line utility function is included for making plots. None of the Python 2 routines were touched, so those should all still work. Additionally, a local pip based installation of the class and utility have been added to the makefile. There are still some things which could be added:
Regarding the 3D surface plots, my preference is to use the Python interface to VTK. But I think this decision should be up to @landreman. I also put myself (@lazersos) as the Python package maintainer but perhaps it would be better to list @landreman.