fix(sdk): deduplicate subagents by name in SubAgentMiddleware#1675
Open
IHEII (IHEII) wants to merge 1 commit intolangchain-ai:mainfrom
Open
fix(sdk): deduplicate subagents by name in SubAgentMiddleware#1675IHEII (IHEII) wants to merge 1 commit intolangchain-ai:mainfrom
IHEII (IHEII) wants to merge 1 commit intolangchain-ai:mainfrom
Conversation
github-actions
bot
added
deepagents
Collaborator
|
Could you include a unit test and an MRE to explain how you're launching things? It's more likely that we'll want to raise a run time error rather than fail silently with last to win |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description
When multiple subagent specs share the same name are registered,
_build_task_toolpreviously built thesubagent_graphsdict and description string directly from the raw list, resulting in duplicate entries in the tool description presented to the LLM.How this commit works
This fix deduplicates subagents by name (last-one-wins) before building the graphs dict and description string, ensuring each subagent appears only once.
How was this verified?
Manually tested with a configuration that registers duplicate subagent names and confirmed the generated tool description no longer contains duplicates.