Skip to content

Conversation

@katmayb
Copy link
Contributor

@katmayb katmayb commented Nov 21, 2025

@github-actions github-actions bot added the langsmith For docs changes to LangSmith label Nov 21, 2025
@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-lspara-1763745059-0a4120f

@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-lspara-1763745143-63878e4

@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-lspara-1763745239-63b18ee

@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-lspara-1763761024-e80127d

@katmayb katmayb requested a review from jacoblee93 November 21, 2025 21:41
run_type="llm",
metadata={
"ls_provider": "my_provider",
"ls_model_name": "my_custom_model"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work without model type but we should double check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I ran this and it seemed to work fine — trace in project containing metadata. So, I've taken out mentions of ls_model_type from the page. Let me know if there is something else I should test with regards to that.

metadata={
"ls_provider": "openai",
"ls_model_name": "gpt-4o",
"ls_model_type": "chat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to flip flip - if the above works, let's actually remove this from examples

@github-actions
Copy link
Contributor

Mintlify preview ID generated: preview-lspara-1764006654-a0aa62e

@katmayb katmayb marked this pull request as ready for review November 24, 2025 19:01
@katmayb katmayb requested a review from lnhsingh as a code owner November 24, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

langsmith For docs changes to LangSmith

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants