Skip to content

create dedicated documentation for nostream tag#2916

Merged
Naomi Pentrel (npentrel) merged 10 commits intomainfrom
naomi/doc-507-create-dedicated-documentation-for-nostream-tag
Apr 2, 2026
Merged

create dedicated documentation for nostream tag#2916
Naomi Pentrel (npentrel) merged 10 commits intomainfrom
naomi/doc-507-create-dedicated-documentation-for-nostream-tag

Conversation

@npentrel
Copy link
Copy Markdown
Contributor

@npentrel Naomi Pentrel (npentrel) commented Mar 4, 2026 •
edited
Loading

@github-actions github-actions bot added ci deepagents For docs changes to Deep Agents docs-infra javascript langchain For docs changes to LangChain langgraph For docs changes to LangGraph langsmith For docs changes to LangSmith oss python For content related to the Python version of LangChain projects tests internal labels Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Mintlify preview ID generated: preview-naomid-1772638260-f3b1cc6

@npentrel Naomi Pentrel (npentrel) force-pushed the naomi/doc-507-create-dedicated-documentation-for-nostream-tag branch from 9caaa6b to 3d3a8ba Compare March 4, 2026 15:39
@github-actions github-actions bot removed deepagents For docs changes to Deep Agents docs-infra langsmith For docs changes to LangSmith langchain For docs changes to LangChain tests labels Mar 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Mintlify preview ID generated: preview-naomid-1772638854-b9dfa50

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Mintlify preview ID generated: preview-naomid-1772639696-82e1504

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Mintlify preview ID generated: preview-naomid-1772640292-7a86a09

@npentrel Naomi Pentrel (npentrel) force-pushed the naomi/doc-507-create-dedicated-documentation-for-nostream-tag branch from 434522b to 17a4c65 Compare March 4, 2026 17:00
@npentrel Naomi Pentrel (npentrel) force-pushed the naomi/doc-507-create-dedicated-documentation-for-nostream-tag branch from 17a4c65 to cd21f58 Compare March 4, 2026 17:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 4, 2026

Mintlify preview ID generated: preview-naomid-1772643850-bf75eb9

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Mintlify preview ID generated: preview-naomid-1772798439-b1e1147

npentrel
Naomi Pentrel (npentrel) commented Mar 6, 2026
View reviewed changes
Comment thread scripts/generate_code_snippet_mdx.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

Mintlify preview ID generated: preview-naomid-1772799020-1e2e553

sydney-runkle
Sydney Runkle (sydney-runkle) reviewed Mar 9, 2026
View reviewed changes
Comment thread src/code-samples/langchain/nostream-tag.py Outdated
"public_response": "",
"internal_analysis": "",
}
stream = graph.stream(cast("Any", initial_state), stream_mode="messages")
Copy link
Copy Markdown
Contributor

@sydney-runkle Sydney Runkle (sydney-runkle) Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should never do this cast in docs, why is this here?

Copy link
Copy Markdown
Contributor Author

@npentrel Naomi Pentrel (npentrel) Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter was unhappy without it, let me try to remove it

sydney-runkle
Sydney Runkle (sydney-runkle) reviewed Mar 9, 2026
View reviewed changes
Comment thread src/code-samples/langchain/nostream-tag.py Outdated
sydney-runkle
Sydney Runkle (sydney-runkle) requested changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sydney-runkle Sydney Runkle (sydney-runkle) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using scripts now for inline snippets? why?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Mintlify preview ID generated: preview-naomid-1773073478-6a32904

sydney-runkle
Sydney Runkle (sydney-runkle) reviewed Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sydney-runkle Sydney Runkle (sydney-runkle) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we show output? should we show a more simple snippet in the docs?

@npentrel
Copy link
Copy Markdown
Contributor Author

Naomi Pentrel (npentrel) commented Mar 9, 2026

Since the output is that nothing is being streamed I'm not sure it's strictly needed but we could add it. What are you thinking for a simpler snippet? Just the config?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Mintlify preview ID generated: preview-naomid-1775136072-ecb3d68

@npentrel Naomi Pentrel (npentrel) force-pushed the naomi/doc-507-create-dedicated-documentation-for-nostream-tag branch from 5f9fada to 42b732b Compare April 2, 2026 13:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Mintlify preview ID generated: preview-naomid-1775136670-6af6660

sydney-runkle
Sydney Runkle (sydney-runkle) approved these changes Apr 2, 2026
View reviewed changes
Comment thread src/snippets/code-samples/nostream-tag-py.mdx Outdated
)

initial_state: State = {"topic": "AI", "answer": "", "notes": ""}
stream = graph.stream(initial_state, stream_mode="messages") # type: ignore[arg-type]
Copy link
Copy Markdown
Contributor

@sydney-runkle Sydney Runkle (sydney-runkle) Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't have to use type ignore

Copy link
Copy Markdown
Contributor

@sydney-runkle Sydney Runkle (sydney-runkle) Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we build this into agents.md or something that it should flag and try to correct

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Mintlify preview ID generated: preview-naomid-1775141729-d6fd171

@npentrel Naomi Pentrel (npentrel) merged commit ac86ac4 into main Apr 2, 2026
21 checks passed
@npentrel Naomi Pentrel (npentrel) deleted the naomi/doc-507-create-dedicated-documentation-for-nostream-tag branch April 2, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sydney-runkle Sydney Runkle (sydney-runkle) sydney-runkle approved these changes

@katmayb Kathryn May (katmayb) Awaiting requested review from katmayb

@fjmorris Florence Morris (fjmorris) Awaiting requested review from fjmorris

@mdrxy Mason Daugherty (mdrxy) Awaiting requested review from mdrxy

@lnhsingh Lauren Hirata Singh (lnhsingh) Awaiting requested review from lnhsingh

@hinthornw William FH (hinthornw) Awaiting requested review from hinthornw

Assignees

No one assigned

Labels

ci internal javascript langgraph For docs changes to LangGraph oss python For content related to the Python version of LangChain projects

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npentrel @sydney-runkle