Closed
Conversation
Switched links for simple vs custom mcp auth
Contributor
|
Thanks for opening a docs PR, Dev Gupta (@Splashing23)! When it's ready for review, please add the relevant reviewers:
|
github-actions
bot
added
langchain
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the LangChain MCP documentation to adjust which external references are used for “simple vs custom” MCP authentication guidance.
Changes:
- Swaps the two GitHub links under the “Authentication” section in
mcp.mdx. - Updates the bullet list ordering/label-to-URL association for the OAuth/custom-auth references.
Comment on lines
+472
to
+473
| * [Built-in OAuth flow](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-auth-client/mcp_simple_auth_client/main.py) | ||
| * [Example custom auth implementation](https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/client/auth/oauth2.py#L216) |
There was a problem hiding this comment.
The link labels appear swapped: the “Built-in OAuth flow” label currently points to the simple-auth-client example file, while “Example custom auth implementation” points to src/mcp/client/auth/oauth2.py (which looks like the OAuth implementation). Please swap the URLs (or swap the labels) so each label matches its destination.
Suggested change
| * [Built-in OAuth flow](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-auth-client/mcp_simple_auth_client/main.py) | |
| * [Example custom auth implementation](https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/client/auth/oauth2.py#L216) | |
| * [Built-in OAuth flow](https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/client/auth/oauth2.py#L216) | |
| * [Example custom auth implementation](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-auth-client/mcp_simple_auth_client/main.py) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched links for simple vs custom mcp auth
Overview
Type of change
Type: [Replace with: New documentation page / Update existing documentation / Fix typo/bug/link/formatting / Remove outdated content / Other]
Related issues/PRs
Checklist
docs devsrc/docs.jsonif needed(Internal team members only / optional): Create a preview deployment as necessary using the Create Preview Branch workflow
Additional notes