Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add inference component support to SageMaker Endpoint #229

Merged
merged 4 commits into from
Oct 4, 2024
Merged

add inference component support to SageMaker Endpoint #229

merged 4 commits into from
Oct 4, 2024
+125 −14

Conversation

pravali96
Copy link
Contributor

  • add inference component support to SageMaker Endpoint
  • add corresponding tests in SageMaker Endpoint integration tests.

@pravali96 pravali96 marked this pull request as ready for review October 4, 2024 19:35
@3coins 3coins self-assigned this Oct 4, 2024
3coins
3coins reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravali96
Thanks for submitting this change. One minor comment for the docs, looks good otherwise.

libs/aws/langchain_aws/llms/sagemaker_endpoint.py Outdated Show resolved Hide resolved
@3coins 3coins merged commit dabdd99 into langchain-ai:main Oct 4, 2024
12 checks passed
@pravali96 pravali96 deleted the sm_endpoint branch October 4, 2024 22:59
@3coins
Copy link
Collaborator

3coins commented Oct 4, 2024 •
edited
Loading

@pravali96
Can you also submit a backport against branch v0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3coins 3coins 3coins approved these changes

Assignees

@3coins 3coins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pravali96 @3coins