Skip to content

Conversation

@ltoniazzi
Copy link

Proposal

Currently AgentCoreSaver async methods fall back to the sync ones.

But this can cause blocking i/o calls, for example when parallel nodes trigger aput_writes (which I think runs async like in here, using this).

By sending the sync methods to another thread we solve the above problems, and we should be already quite efficient as the sync methods mostly perform a single sync call to AgentCore Memory.

Changes

  1. Wrap sync methods in run_in_executor for async versions
  2. Add two tests for each method, (a) assert the sync method is called correctly, (b) assert the total time of multiple async execution is equal to a single one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant