Run AgentCoreSaver async methods with executor #776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Currently
AgentCoreSaverasync methods fall back to the sync ones.But this can cause blocking i/o calls, for example when parallel nodes trigger
aput_writes(which I think runs async like in here, using this).By sending the sync methods to another thread we solve the above problems, and we should be already quite efficient as the sync methods mostly perform a single sync call to AgentCore Memory.
Changes
run_in_executorfor async versions