-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Add Naver chat model & embeddings #25162
base: master
Are you sure you want to change the base?
community: Add Naver chat model & embeddings #25162
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d2f5b2a
to
0797c7e
Compare
1992ee6
to
bdcb421
Compare
Hello @efriis, We've been preparing for this community package and waiting for review (following up our prior communication on early August via email), and I think we are all ready to go! Could you check this PR? |
253b9ff
to
a575045
Compare
Thanks for the ping! Could you get CI passing? |
5548cc3
to
79edab0
Compare
Thanks @efriis , seems we referred to some outdated docs, got failed linting test. |
5959105
to
9898831
Compare
78fe51b
to
6632871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guessing there will be a sizable number of CI failures on this - feel free to click in and see the issues! To run linting+testing yourself locally you can
cd libs/community
poetry install --with lint,typing --sync
make lint
and
cd libs/community
poetry install --with lint,typing,test
make test
also pinged you on slack for an api key for testing! |
actually scratch the api key - let's address the above comments and get CI passing! |
�Could you please guide me to the Slack channel? I don't know where it is. |
You responded to me on Friday! Is this Joonha? |
…tic method to member method
10b5fe5
to
134d18c
Compare
@efriis , Sorry for any confusion. This is our team account and there was a little communication gap between us. Checked Joonha (PM) has sent you the api key :) Done with all review comments, and also got no fail when linting + testing from our own, so I think it's good to go! |
c1b142c
to
d3b2de6
Compare
d3b2de6
to
0fed7f8
Compare
Hi @efriis , I think we missed the release v0.3.1 for langchain-community. Do you plan this to be included in v0.3.2?
|
Hi @efriis , I have fixed some issue on your commands. Please check fixed commit. |
Reopened as a personal repo outside the organization.
Description
Twitter handle: None. (if needed, contact with [email protected])
you can check our previous discussion below:
I would like to keep it as is, unless it is essential to unify the package name.
(ClovaX is a branding for the model, and I plan to add other models and components. They need to be managed as separate classes.)
There are 3 models that are being serviced by embedding, and all are supported in the current PR. In addition, all the functionality of CLOVA Studio that serves actual models, such as distinguishing between test apps and service apps, is supported. The existing PR does not support this content because it is hard-coded.