Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Problem with embeddings in new versions of clickhouse. #26041

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

MarceloNunesAlves
Copy link

Starting with Clickhouse version 24.8, a different type of configuration has been introduced in the vectorized data ingestion, and if this configuration occurs, an error occurs when generating the table. As can be seen below:

Screenshot from 2024-09-04 11-48-00

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 2:06pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 4, 2024
@MarceloNunesAlves
Copy link
Author

Hey @eyurtsev!

Could you review the code please?

@efriis
Copy link
Member

efriis commented Sep 7, 2024

Howdy! Marking as needs support per our review policy. If someone from clickhouse lets us know this is correct happy to accelerate it through - @mneedham maybe?

@mneedham
Copy link
Contributor

This change looks good to me.

@MarceloNunesAlves
Copy link
Author

@efriis, do you think you need someone else to review?

Thank you so much!

@efriis efriis enabled auto-merge (squash) September 11, 2024 23:17
@efriis efriis self-assigned this Sep 11, 2024
auto-merge was automatically disabled September 12, 2024 00:00

Head branch was pushed to by a user without write access

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
@MarceloNunesAlves
Copy link
Author

@efriis,

When running the pipeline, an error occurred that did not occur on my local machine because the configuration is different, sorry.

image

@MarceloNunesAlves
Copy link
Author

@efriis, could you review my code, please? I need this fix to use clickhouse latest.

Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Needs support
Development

Successfully merging this pull request may close these issues.

3 participants