chatperplexity stream-citations in additional kwargs #29273
Merged
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
ccurme
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Thanks!
Same comments as in #29176:
- Needs test
- Unclear that this will play nicely with merging behavior, i.e.,
full = None
for chunk in llm.stream(query):
full = chunk if full is None else full + chunkSee comment in the other PR. That one has been open a few days so will keep this open despite the duplicate in case you want to iterate on it.
dosubot
bot
added
size:M
ccurme
approved these changes
Jan 18, 2025
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chatperplexity stream-citations in additional kwargs