Skip to content

Conversation

@sydney-runkle
Copy link
Collaborator

@sydney-runkle sydney-runkle commented Nov 20, 2025

  • create_agent's system_prompt allows str | SystemMessage
  • added system_message: SystemMessage on ModelRequest
  • ModelRequest.system_prompt is a function of system_message.text, now deprecated
  • disallow setting system_prompt and system_message
  • ModelRequest.system_prompt can still be set (w/ custom setattr) for custom backwards compat, but the updates just get propogated to the ModelRequest.system_message

@github-actions github-actions bot added langchain Related to the package `langchain` feature and removed feature labels Nov 20, 2025
@ccurme ccurme requested review from ccurme and mdrxy as code owners November 21, 2025 22:55
@github-actions github-actions bot added integration Related to a provider partner package integration anthropic labels Nov 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #34055 will not alter performance

Comparing sr/system-prompt-again (bd4c53e) with master (eb0545a)

Summary

✅ 3 untouched
⏩ 31 skipped1

Footnotes

  1. 31 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions github-actions bot added feature and removed feature labels Nov 23, 2025
@github-actions github-actions bot added feature and removed feature labels Nov 23, 2025
@mdrxy mdrxy changed the title feat: support SystemMessage in create_agent's system_prompt feat(langchain): support SystemMessage in create_agent's system_prompt Nov 24, 2025
@github-actions github-actions bot added feature and removed feature labels Nov 24, 2025
@sydney-runkle sydney-runkle enabled auto-merge (squash) November 24, 2025 14:52
@sydney-runkle sydney-runkle merged commit 4ab9457 into master Nov 24, 2025
63 checks passed
@sydney-runkle sydney-runkle deleted the sr/system-prompt-again branch November 24, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

anthropic feature integration Related to a provider partner package integration langchain Related to the package `langchain`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants