-
Notifications
You must be signed in to change notification settings - Fork 20.1k
feat(langchain): Add support to google_genai provider in init_embeddings
#34388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Christophe-Lamarche-Cossette
wants to merge
10
commits into
langchain-ai:master
Choose a base branch
from
Christophe-Lamarche-Cossette:cossette-christophe-lamarche/embeddings-factory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−24
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d918e1d
Add Google GenAI as provider for embeddings factory
Christophe-Lamarche-Cossette 166d854
Test: Add/Refactor unit test for embedding/base.py.
Christophe-Lamarche-Cossette 7baf378
Fix: Whitespace
Christophe-Lamarche-Cossette a81c647
Fix: missing type annotation
Christophe-Lamarche-Cossette ff65b4d
Fix: Wrong order of expected output
Christophe-Lamarche-Cossette 0113606
Fix: Import order
Christophe-Lamarche-Cossette 171dbd6
Merge branch 'master' into cossette-christophe-lamarche/embeddings-fa…
Christophe-Lamarche-Cossette aee630e
Feature: Add modifications to langchain_v1
Christophe-Lamarche-Cossette 8da2e13
Fix: Formatting error
Christophe-Lamarche-Cossette 87a4ca1
Fix: Too many linejump
Christophe-Lamarche-Cossette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also expect this to be applied to
libs/langchain_v1/langchain/embeddings/base.pyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. The changes are applied to the
langchain_v1lib as well.