Skip to content

fix(core): prevent redundant re-embedding in incremental indexing with batch_size #35631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alon Naor (AlonNaor22) wants to merge 1 commit into
base: master
Choose a base branch
from

fix(core): move incremental cleanup after batch loop to prevent redun…

356d491
Select commit
Loading
Failed to load commit list.
Open

fix(core): prevent redundant re-embedding in incremental indexing with batch_size #35631

fix(core): move incremental cleanup after batch loop to prevent redun…
356d491
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis succeeded Mar 7, 2026 in 0s

Performance Gate Passed

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 13 untouched benchmarks
⏩ 23 skipped benchmarks1

Comparing AlonNaor22:fix/incremental-indexing-batch-size-bug (356d491) with master (29134dc)

Open in CodSpeed

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ