fix(core): handle Pydantic-incompatible types in injected tool args#35636
Open
Alon Naor (AlonNaor22) wants to merge 1 commit intolangchain-ai:masterfrom
Open
fix(core): handle Pydantic-incompatible types in injected tool args#35636Alon Naor (AlonNaor22) wants to merge 1 commit intolangchain-ai:masterfrom
Alon Naor (AlonNaor22) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
When a tool parameter is annotated with InjectedToolArg and typed as a Protocol union (e.g. StateLike), Pydantic's validate_arguments crashes with SchemaError because Protocol types are not valid for isinstance checks. This catches PydanticSchemaError and retries with the injected arg annotations replaced by Annotated[Any, InjectedToolArg()], which preserves the injected marker while using a Pydantic-safe type. Closes langchain-ai#32067 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merging this PR will not alter performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InjectedToolArgand typed as a Pydantic-incompatible type (e.g. a Protocol union likeStateLike)PydanticSchemaErrorduringvalidate_argumentsand retries with injected arg annotations replaced byAnnotated[Any, InjectedToolArg()], preserving the injected marker while using a Pydantic-safe typeCloses #32067
Files changed
libs/core/langchain_core/tools/base.py— try/except increate_schema_from_functionto handle SchemaError for injected argslibs/core/tests/unit_tests/test_tools.py— 2 new tests: Protocol union type (reproduces Potential validation issue when usingStateLikeinAnnotationfor a tool #32067) and multiple injected arg typesTest plan
test_injected_arg_with_protocol_union_type— verifies tool withAnnotated[StateLike, InjectedToolArg]can be created and invokedtest_injected_arg_filtered_from_schema_at_creation— verifies bothInjectedToolArgand_DirectlyInjectedToolArgtypes work correctlytest_tools.pypass (no regressions)🤖 Generated with Claude Code