Skip to content

fix: off-by-one error in RecursiveJsonSplitter.split_json #35649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ethan T. (gambletan) wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

fix: off-by-one error in RecursiveJsonSplitter.split_json #35649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions libs/text-splitters/langchain_text_splitters/json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,21 @@ def _json_split(
size = self._json_size({key: value})
remaining = self.max_chunk_size - chunk_size

if size < remaining:
if size <= remaining:
# Add item to current chunk
self._set_nested_dict(chunks[-1], new_path, value)
else:
if chunk_size >= self.min_chunk_size:
# Chunk is big enough, start a new chunk
chunks.append({})

# Iterate
self._json_split(value, new_path, chunks)
# Only recurse into non-empty dicts; for leaf values
# and empty dicts, add them directly to the current chunk
# so they are not silently dropped.
if isinstance(value, dict) and value:
self._json_split(value, new_path, chunks)
else:
self._set_nested_dict(chunks[-1], new_path, value)
else:
# handle single item
self._set_nested_dict(chunks[-1], current_path, data)
Expand Down