fix(langchain-classic): fix Chain.save() regression from dict-to-model_dump migration#35667
Open
Mohammad Mohtashim (keenborder786) wants to merge 1 commit intolangchain-ai:masterfrom
Open
Conversation
github-actions
bot
added
fix
Mohammad Mohtashim (keenborder786)
changed the title
github-actions
bot
added
fix
org-membership-reviewer
bot
added
the
trusted-contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #33035 where Chain.save() stopped working for all chain types (including LLMChain).
The root cause is that #33035 updated save() to call self.model_dump() but forgot to rename the dict() method override to model_dump(). So the _type key was never being injected into the serialized output, and save() would always hit the "does not support saving" error path.
Renamed the override from dict to model_dump to fix it. Pydantic v2's dict() already delegates to model_dump() under the hood, so nothing breaks.
Fixes: #35665