Skip to content

fix(core): add missing -> None return type to Tee.__init__() in iter …#35682

Open
Debashish Mohapatra (debashish-datascience1) wants to merge 2 commits intolangchain-ai:masterfrom
debashish-datascience1:fix/my-contribution
Open

fix(core): add missing -> None return type to Tee.__init__() in iter …#35682
Debashish Mohapatra (debashish-datascience1) wants to merge 2 commits intolangchain-ai:masterfrom
debashish-datascience1:fix/my-contribution

Conversation

@debashish-datascience1
Copy link

@debashish-datascience1 Debashish Mohapatra (debashish-datascience1) commented Mar 9, 2026

Summary

Added missing -> None return type annotation to Tee.__init__()
in langchain_core/utils/iter.py for both sync and async implementations.

Changes

  • Added -> None return type to Tee.__init__()
  • Added -> None return type to Tee.__aiter__()

Why

Improves type safety and consistency with Python typing best practices.
No functional changes — annotation fix only.

Testing

No tests required — this is a type annotation fix only.

@github-actions github-actions bot added core `langchain-core` package issues & PRs external fix For PRs that implement a fix labels Mar 9, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 13 untouched benchmarks
⏩ 23 skipped benchmarks1


Comparing debashish-datascience1:fix/my-contribution (d26c0fa) with master (fcca6e2)2

Open in CodSpeed

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (7cef35b) during the generation of this report, so fcca6e2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions bot added fix For PRs that implement a fix and removed fix For PRs that implement a fix labels Mar 9, 2026
@org-membership-reviewer org-membership-reviewer bot added the size: XS < 50 LOC label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core `langchain-core` package issues & PRs external fix For PRs that implement a fix size: XS < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant