ci: decouple codspeed from ci gate#36051
Merged
Mason Daugherty (mdrxy) merged 3 commits intomasterfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodSpeed benchmarks shared the main CI workflow's concurrency group, which has
cancel-in-progress: true. On push-to-master (post-merge), back-to-back merges would cancel in-flight CodSpeed jobs — failing theci_successgate and marking the merge commit red, even though the PR passed all checks before merging. The cancelled jobs also meant baseline benchmark data was never uploaded, silently breaking CodSpeed's regression detection for subsequent PRs.Changes
codspeed.ymlworkflow with its own concurrency group — push-to-master runs usegithub.shaas the group key (unique per commit, never cancelled), while PR runs continue to cancel stale runs viagithub.refcodspeedjob, its output, and itsci_successgate dependency fromcheck_diffs.yml— benchmark results are informational and shouldn't block mergesReview
build(change detection) job fromcheck_diffs.ymlsince it can't reference jobs across workflows. This means an extracheck_diff.pyrun per trigger, but it's lightweight (~2s) and the tradeoff is worth the isolation.