Skip to content

ci: decouple codspeed from ci gate#36051

Merged
Mason Daugherty (mdrxy) merged 3 commits intomasterfrom
mdrxy/codspeed-gate
Mar 18, 2026
Merged

ci: decouple codspeed from ci gate#36051
Mason Daugherty (mdrxy) merged 3 commits intomasterfrom
mdrxy/codspeed-gate

Conversation

@mdrxy
Copy link
Member

@mdrxy Mason Daugherty (mdrxy) commented Mar 18, 2026

CodSpeed benchmarks shared the main CI workflow's concurrency group, which has cancel-in-progress: true. On push-to-master (post-merge), back-to-back merges would cancel in-flight CodSpeed jobs — failing the ci_success gate and marking the merge commit red, even though the PR passed all checks before merging. The cancelled jobs also meant baseline benchmark data was never uploaded, silently breaking CodSpeed's regression detection for subsequent PRs.

Changes

  • Extract CodSpeed into a standalone codspeed.yml workflow with its own concurrency group — push-to-master runs use github.sha as the group key (unique per commit, never cancelled), while PR runs continue to cancel stale runs via github.ref
  • Remove the codspeed job, its output, and its ci_success gate dependency from check_diffs.yml — benchmark results are informational and shouldn't block merges

Review

  • The new workflow duplicates the build (change detection) job from check_diffs.yml since it can't reference jobs across workflows. This means an extra check_diff.py run per trigger, but it's lightweight (~2s) and the tradeoff is worth the isolation.

@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code infra PRs made that include chores, devops, repo meta changes internal size: XS < 50 LOC labels Mar 18, 2026
@github-actions github-actions bot added size: S 50-199 LOC and removed size: XS < 50 LOC labels Mar 18, 2026
@mdrxy Mason Daugherty (mdrxy) merged commit a81203b into master Mar 18, 2026
91 checks passed
@mdrxy Mason Daugherty (mdrxy) deleted the mdrxy/codspeed-gate branch March 18, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code infra PRs made that include chores, devops, repo meta changes internal size: S 50-199 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant