Fixed InjectedToolArg filtering bypassed when filter_args provided

[Tim Ren (xr843)]

Summary

Fixes #35831

• Bug: When filter_args is provided alongside include_injected=False in create_schema_from_function, the InjectedToolArg-annotated parameter filtering is skipped entirely. This causes parameters meant to be hidden from the LLM (e.g., API keys, internal state) to leak into the generated JSON schema.
• Root cause: The injected-arg filtering block was nested inside the else branch of if filter_args:, so it only ran when filter_args was not provided.
• Fix: Moved the InjectedToolArg filtering outside the if/else block so it always runs regardless of whether filter_args was provided. Also copies filter_args to a local list to avoid mutating the caller's sequence.

Security implications

This is a security-relevant fix. InjectedToolArg is commonly used to annotate sensitive parameters (API keys, tokens, internal state) that should never be exposed in the tool schema sent to an LLM. The bug caused these parameters to leak into the schema when filter_args was explicitly provided.

Test plan

• Added regression test test_create_schema_injected_arg_filtered_with_filter_args that verifies:
  • InjectedToolArg-annotated parameters are excluded from the schema even when filter_args is provided
  • The caller's filter_args sequence is not mutated
• Test passes locally

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

[github-actions]

This PR has been automatically closed because you are not assigned to the linked issue.

External contributors must be assigned to an issue before opening a PR for it. Please:

1. Comment on the linked issue to request assignment from a maintainer
2. Once assigned, edit your PR description and the PR will be reopened automatically