fix(chroma): reject async chroma clients with a clear error#36692
Closed
lakshayt7 wants to merge 2 commits intolangchain-ai:masterfrom
Closed
fix(chroma): reject async chroma clients with a clear error#36692lakshayt7 wants to merge 2 commits intolangchain-ai:masterfrom
lakshayt7 wants to merge 2 commits intolangchain-ai:masterfrom
Conversation
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30704
Summary
Reject awaitable Chroma clients passed to
langchain_chroma.Chromawith a clearTypeErrorinstead of failing later with anAttributeError.Why
Passing
chromadb.AsyncHttpClient(...)currently produces an awaitable, andChromalater crashes during collection setup with'coroutine' object has no attribute 'get_or_create_collection'. This change fails fast with an actionable message that points users to a synchronous client.Changes
clientduringChromainitializationTypeErrorwhen an awaitable client is providedchromadb.AsyncHttpClient(...)Testing
pytest tests/unit_tests/test_vectorstores.py -qAI Disclosure
This PR was prepared with assistance from an AI coding agent, then reviewed and submitted by me.