fix(core): prevent tool descriptions from inheriting parent class doc…#36693
Closed
SaVi (SaVi456) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
fix(core): prevent tool descriptions from inheriting parent class doc…#36693SaVi (SaVi456) wants to merge 1 commit intolangchain-ai:masterfrom
SaVi (SaVi456) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
…strings Child classes without their own docstring silently inherited the parent's via Python's MRO, causing misleading tool descriptions in function-calling APIs. Add _get_own_doc() helper that checks __dict__ directly instead of traversing the MRO, and apply it at all description-resolution sites. Closes #32066 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
core
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_own_doc()helper inlangchain_core/utils/pydantic.pythat checks__dict__directly instead of traversing the MROstructured.py,convert.py, andpydantic.pyTest plan
test_tools.pypass (0 regressions)test_pydantic.pypasstest_function_calling.pypass