fix(langchain): handle done markers after stdout without trailing newline#36695
Closed
nu1lx wants to merge 1 commit intolangchain-ai:masterfrom
Closed
fix(langchain): handle done markers after stdout without trailing newline#36695nu1lx wants to merge 1 commit intolangchain-ai:masterfrom
nu1lx wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36696
Summary
Why
ShellSessioncurrently only recognizes completion when a stdout line starts with the done marker. If a command writes stdout without a trailing newline, the injected marker is appended to that same line instead. In that case, the marker is missed and the command can time out even though it already finished.Testing
uv run ruff check langchain/agents/middleware/shell_tool.py tests/unit_tests/agents/middleware/implementations/test_shell_tool.pyuv run pytest tests/unit_tests/agents/middleware/implementations/test_shell_tool.py -k 'stdout_without_trailing_newline or truncated_stdout_without_trailing_newline or stderr_output_labeling'AI disclaimer
This PR was drafted with the help of an AI coding agent, then reviewed and refined by a human.