fix(openai): handle missing cached/reasoning tokens in service_tier math#36946
Closed
zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
fix(openai): handle missing cached/reasoning tokens in service_tier math#36946zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
service_tier math#36946zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36657
When
service_tierispriorityorflex,_create_usage_metadata(and the responses-API equivalent) compute the per-tier input/output token counts by subtracting cached and reasoning tokens from the totals. Both detail dicts are populated via.get("cached_tokens")/.get("reasoning_tokens"), which storeNonewhen the API omits the field. The follow-updict.get(key, 0)then returnsNone(the key exists with valueNone), andint - NoneraisesTypeError.Switching to
dict.get(key) or 0coerces the absent-or-Nonecase to0, matching the pattern already used elsewhere in this module after #36500. Adds regression tests for both helpers covering the empty-*_tokens_detailspath withservice_tierset.