test(core): fix expected generations shape in test_stream_error_callback#36947
Closed
zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
test(core): fix expected generations shape in test_stream_error_callback#36947zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
generations shape in test_stream_error_callback#36947zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36866
test_stream_error_callbackwas markedxfailbecause thei == 0branch assertedllm_result.generations == [], but the callback receives anLLMResultwhosegenerationspreserves the batch dimension — the actual value is[[]]. Since #30228 the assertion executes correctly, so thexfailwas hiding a stale test expectation rather than a product bug.Fix updates the assertion to
[[]]and removes thexfailmarker so the test now exercises and protects the callback path.