fix(core): escape raw \r and \t in parse_partial_json strings#36948
Closed
zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
fix(core): escape raw \r and \t in parse_partial_json strings#36948zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
\r and \t in parse_partial_json strings#36948zxuhan7 (zxuhan) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
zxuhan7 (zxuhan)
requested a review
from Eugene Yurtsev (eyurtsev)
as a code owner
github-actions
Bot
added
core
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36747
parse_partial_jsonalready replaces a raw\ninside a JSON string value with the\\nescape sequence so the partial parse can succeed understrict=True(RFC 8259 forbids unescaped control characters in strings). Models also commonly emit raw\rand\t, which currently fall through and causejson.JSONDecodeError: Invalid control character at: ....The fix factors the per-character substitution into a small
{"\n": "\\n", "\r": "\\r", "\t": "\\t"}map and escapes the same way for all three. Other control characters (\b,\f,\x00–\x1f) remain unhandled, matching the prior scope. Adds a parametrised regression test covering each escape understrict=True.