fix(chroma): raise ValueError when async client is passed to Chroma#36950
Closed
anish (anishesg) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
fix(chroma): raise ValueError when async client is passed to Chroma#36950anish (anishesg) wants to merge 1 commit intolangchain-ai:masterfrom
ValueError when async client is passed to Chroma#36950anish (anishesg) wants to merge 1 commit intolangchain-ai:masterfrom
Conversation
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30704
Passing a
chromadb.AsyncHttpClientto theChromaconstructor causes a confusingAttributeError: 'coroutine' object has no attribute 'get_or_create_collection'. This happens becauseAsyncHttpClientis an async factory that returns a coroutine, and the sync__ensure_collectionmethod tries to call.get_or_create_collection()on it directly.This adds early validation in
__init__to detect two cases:AsyncHttpClient(...)call (a coroutine object)AsyncClientAPIinstanceBoth now raise a
ValueErrorwith a clear message pointing the user tochromadb.HttpClientas the synchronous alternative.