fix(core): ensure tracing context is checked when callbacks=None#36951
Closed
Mateus Scheuer Macedo (MestreY0d4-Uninter) wants to merge 1 commit intolangchain-ai:masterfrom
Closed
Conversation
- Add explicit check for global tracing context when both inheritable_callbacks and local_callbacks are None - This fixes issue langchain-ai#30870 where llm.ainvoke() tracing was not working in async contexts where contextvars may not propagate automatically - The fix ensures tracing_tags and tracing_metadata are always consulted even when callbacks=None is passed explicitly Fixes: langchain-ai#30870
Mateus Scheuer Macedo (MestreY0d4-Uninter)
requested a review
from Eugene Yurtsev (eyurtsev)
as a code owner
github-actions
Bot
added
core
|
This PR has been automatically closed because you are not assigned to the linked issue. External contributors must be assigned to an issue before opening a PR for it. Please:
Maintainers: reopen this PR or remove the |
5 tasks
Mateus Scheuer Macedo (MestreY0d4-Uninter)
deleted the
fix/30870-ainvoke-tracing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30870
What changed
Added explicit check for global tracing context when both
inheritable_callbacksandlocal_callbacksare None in the_configurefunction.Why
When
llm.ainvoke()is called without explicit callbacks, the tracing context was not being consulted in async contexts where contextvars may not propagate automatically. This caused tracing to silently fail.How to test
LANGCHAIN_TRACING_V2=truellm.ainvoke()without passing explicit callbacksChanges
libs/core/langchain_core/callbacks/manager.py: Add check for global tracing context when callbacks=NoneAI-assisted contribution.