Skip to content

fix(core): replace 5 unnecessary type: ignore with cast() in ai.py#36981

Closed
Albin George Kurian (albin-george-kurian) wants to merge 1 commit intolangchain-ai:masterfrom
albin-george-kurian:fix-ai-py-type-ignore
Closed

fix(core): replace 5 unnecessary type: ignore with cast() in ai.py#36981
Albin George Kurian (albin-george-kurian) wants to merge 1 commit intolangchain-ai:masterfrom
albin-george-kurian:fix-ai-py-type-ignore

Conversation

@albin-george-kurian
Copy link
Copy Markdown

Fixes #36931

Replaces 5 unnecessary # type: ignore comments in ai.py with
targeted cast(dict[str, Any], ...) usage.

  • Removes suppressed mypy errors
  • No runtime impact
  • Keeps 2 intentional ignores unchanged

All checks passing locally:

  • mypy ✅
  • ruff ✅
  • pytest ✅

@github-actions
Copy link
Copy Markdown

This PR has been automatically closed because you are not assigned to the linked issue.

External contributors must be assigned to an issue before opening a PR for it. Please:

  1. Comment on the linked issue to request assignment from a maintainer
  2. Once assigned, your PR will be reopened automatically

Maintainers: reopen this PR or remove the missing-issue-link label to bypass this check.

@github-actions github-actions Bot closed this Apr 24, 2026
@albin-george-kurian
Copy link
Copy Markdown
Author

My PR (#36981) is ready with all checks passing (mypy, ruff, pytest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core `langchain-core` package issues & PRs external fix For PRs that implement a fix missing-issue-link new-contributor size: XS < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(core): remove 5 unnecessary type: ignore comments in ai.py

1 participant