fix(langchain): sanitize anthropic cache markers on fallback retries#37867
Draft
Hunter Lovell (hntrl) wants to merge 1 commit into
Draft
fix(langchain): sanitize anthropic cache markers on fallback retries#37867Hunter Lovell (hntrl) wants to merge 1 commit into
Hunter Lovell (hntrl) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33709.
When
AnthropicPromptCachingMiddlewareruns beforeModelFallbackMiddleware, Anthropic-specificcache_controlmarkers can leak into fallback attempts targeting non-Anthropic models. This change makes fallback retries sanitize those markers only on non-primary attempts, preserving primary-call behavior and avoiding API changes.Related: langchain-ai/deepagentsjs#551.
Changes
libs/langchain_v1
model_fallback.pyto remove Anthropiccache_controlmarkers from fallback requests.model_settings, system/content message blocks, and tool payloads (BaseTool.extrasplus dict-style tools/extras).wrap_model_callandawrap_model_call) while leaving the primary attempt unchanged.libs/langchain_v1 tests
test_model_fallback.pythat simulate primary failure and assert fallback calls only succeed when cache markers are stripped.temperatureandtop_p) are preserved on fallback.