fix(core): surface helpful error when tool call arguments fail to JSON.parse#10941
Open
devteamaegis wants to merge 1 commit into
Open
fix(core): surface helpful error when tool call arguments fail to JSON.parse#10941devteamaegis wants to merge 1 commit into
devteamaegis wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When `coerceMessageLikeToMessage` receives an OpenAI-style tool call whose `function.arguments` is malformed JSON, the bare `JSON.parse` call inside `_coerceToolCall` (libs/langchain-core/src/messages/utils.ts:198) throws a generic `SyntaxError` with no context: no tool name, no tool call ID, no raw payload. Models do occasionally emit malformed JSON in tool arguments (most commonly when streaming and a chunk is mishandled), so this surfaces as a hard-to-debug exception in user code.
The sibling helper `defaultToolCallParser` in `messages/tool.ts:326` already handles this case by catching `JSON.parse` failures and routing to `invalid_tool_call` — the divergence is only in this one code path.
Fix
Wrap `JSON.parse` in `_coerceToolCall` with a try/catch that re-throws using `addLangChainErrorFields` and includes the tool name, the tool call id, and the raw arguments. Same `MESSAGE_COERCION_FAILURE` code as the sibling unrecognized-shape branch a few lines below.
Diff:
```diff
```
Test
Two new vitest cases in `libs/langchain-core/src/messages/tests/message_utils.test.ts`:
`npx vitest run src/messages/tests/message_utils.test.ts` → 25 passed.
Novelty
`gh search prs --repo langchain-ai/langchainjs _coerceToolCall JSON.parse` returns no matches. No open PR touches this block.