Fix async durability checkpoint backlog#7112
Open
Alexxigang wants to merge 3 commits intolangchain-ai:mainfrom
Open
Fix async durability checkpoint backlog#7112Alexxigang wants to merge 3 commits intolangchain-ai:mainfrom
Alexxigang wants to merge 3 commits intolangchain-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unbounded checkpoint task buildup when running graphs with
durability="async".The root cause is that a new checkpoint write can be chained before the previous async checkpoint future has finished, which allows
_checkpointer_put_after_previoustasks to accumulate across supersteps when checkpoint persistence is slower than graph execution.This change keeps the intended one-superstep overlap for async durability, but waits for the in-flight checkpoint future before chaining the next one.
Changes
loop.after_tick()in the sync Pregel stream pathloop.after_tick()in the async Pregel stream pathTesting
Passed locally:
5 passed in 11.80sIssue
Closes #7094