refactor(chat): improve model name extraction logic in ChatComponent

[ogabrielluiz]

Summary

• Adds _extract_model_name() helper function to handle various model name formats
• Fixes model name extraction when using ModelInput format (list of dicts with 'name' key)
• Handles string, list, and dict formats for model name attributes

Changes

• Added helper function that extracts model name from:
  • String model name (e.g., "gpt-4o-mini")
  • ModelInput format: list of dicts with 'name' key
  • Single dict with 'name' key
• Updated get_properties_from_source_component() to use the new helper

Test plan

• Verify model name displays correctly in chat messages when using different model input formats

Summary by CodeRabbit

• Refactor
  • Enhanced model name extraction logic to support multiple input formats and improve component property retrieval robustness.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Added a helper function _extract_model_name() to normalize model name extraction from multiple formats (string, list of dicts, or dict) and refactored get_properties_from_source_component() to use it, replacing direct truthy checks with a verification-then-extract pattern while maintaining existing fallback behavior.

Changes

Cohort / File(s)	Summary
Model name extraction refactoring src/lfx/src/lfx/base/io/chat.py	Added _extract_model_name() helper function for normalizing model name extraction. Refactored get_properties_from_source_component() to use the helper instead of direct attribute checks, implementing two-step verification (existence check → value extraction) with conditional return logic for model-name-found vs. fallback scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify _extract_model_name() correctly handles all three input formats (string, list of dicts with 'name', dict with 'name')
• Confirm the refactored function properly integrates the helper and maintains backward compatibility via the fallback path
• Check that return tuple structures are correct for both success and fallback scenarios
• Validate edge cases (empty lists, missing 'name' keys, None values)

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 3 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Coverage For New Implementations	❌ Error	The PR introduces a new helper function _extract_model_name() and refactors get_properties_from_source_component() in src/lfx/src/lfx/base/io/chat.py, but no corresponding test files are included.	Create test directory src/lfx/tests/unit/base/io/ and add test_chat.py with comprehensive unit tests for _extract_model_name() and refactored get_properties_from_source_component() method.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Test Quality And Coverage	⚠️ Warning	PR adds implementation file src/lfx/src/lfx/base/io/chat.py with _extract_model_name() and refactored get_properties_from_source_component() but includes no corresponding test file coverage.	Create src/lfx/tests/unit/base/io/test_chat.py with comprehensive pytest tests for both functions, covering all input formats, edge cases, and mocked graph vertex scenarios before merging.
Test File Naming And Structure	⚠️ Warning	Pull request adds new helper function and refactors method in chat.py without corresponding test coverage in expected location.	Create test file at src/lfx/tests/unit/base/io/test_chat.py with TestChatComponent class covering _extract_model_name() and get_properties_from_source_component() methods.
Excessive Mock Usage Warning	❓ Inconclusive	Unable to assess excessive mock usage in test files without access to the actual repository structure and test file contents.	Please provide the test files content or repository information to evaluate mock usage patterns.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: a refactor to improve model name extraction logic in ChatComponent by introducing a new helper function.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/lfx/src/lfx/base/io/chat.py (1)

4-21: Add type hint for the value parameter.

The value parameter is missing a type hint, which reduces code clarity. Consider adding value: Any or a more specific union type if the expected formats are well-defined.

Apply this diff to add a type hint:

+from typing import Any
+
+
-def _extract_model_name(value) -> str | None:
+def _extract_model_name(value: Any) -> str | None:
     """Extract model name from various formats.

Optional: Consider adding runtime type validation.

The function assumes that the "name" key in dictionaries contains a string value, but doesn't validate this. If malformed data is received (e.g., {"name": 123}), the return value would violate the type hint. If data comes from untrusted sources, consider validating that extracted names are strings:

if isinstance(value, dict) and "name" in value:
    name = value["name"]
    return name if isinstance(name, str) else None

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b86351f and 4d0fff3.

📒 Files selected for processing (1)

• src/lfx/src/lfx/base/io/chat.py (2 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-11-24T19:46:57.920Z

Learnt from: CR
Repo: langflow-ai/langflow PR: 0
File: .cursor/rules/icons.mdc:0-0
Timestamp: 2025-11-24T19:46:57.920Z
Learning: Applies to src/backend/**/*component*.py : In Python component classes, set the `icon` attribute to a string matching the desired icon name (e.g., `icon = "AstraDB"`). The string must match the frontend icon mapping exactly (case-sensitive).

Applied to files:

• src/lfx/src/lfx/base/io/chat.py

🧬 Code graph analysis (1)

src/lfx/src/lfx/base/io/chat.py (1)

src/lfx/src/lfx/custom/custom_component/component.py (1)

• get_id (206-207)

🔇 Additional comments (1)

src/lfx/src/lfx/base/io/chat.py (1)

28-44: Nice refactoring that improves maintainability.

The refactored logic clearly separates concerns: checking attribute existence, extracting the value, and normalizing the model name format. The two-step validation (truthy check on line 40, then model_name check on line 42) ensures only valid model names are returned, while the fallback on line 44 preserves backwards compatibility.

[github-actions]

Frontend Unit Test Coverage Report

Coverage Summary

Lines	Statements	Branches	Functions
	16.64% (4686/28150)	9.99% (2179/21792)	10.93% (676/6181)

Unit Test Results

Tests	Skipped	Failures	Errors	Time
1829	0 💤	0 ❌	0 🔥	24.942s ⏱️

[codecov]

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.10%. Comparing base (b86351f) to head (ba85df7).

Files with missing lines	Patch %	Lines
src/lfx/src/lfx/base/io/chat.py	6.25%	14 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11050      +/-   ##
==========================================
- Coverage   33.11%   33.10%   -0.02%     
==========================================
  Files        1389     1389              
  Lines       65714    65728      +14     
  Branches     9730     9736       +6     
==========================================
- Hits        21760    21757       -3     
- Misses      42836    42852      +16     
- Partials     1118     1119       +1     

Flag	Coverage Δ
backend	52.39% <ø> (-0.02%)	⬇️
frontend	15.34% <ø> (ø)
lfx	39.24% <6.25%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/lfx/src/lfx/base/io/chat.py	46.87% <6.25%> (-30.91%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.