Skip to content

Conversation

@mendonk
Copy link
Collaborator

@mendonk mendonk commented Dec 18, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs-docusaurus-versioning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mendonk mendonk self-assigned this Dec 18, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 18, 2025
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 18, 2025
@github-actions

This comment has been minimized.

Copy link
Collaborator

@aimurphy aimurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this configuration tbh.

  • I see this pill thing but I don't see a version switcher or version in the URL. Is that because there's only one version?

    • image
  • You might want to check that slugs are working (maybe not able to check this until we have 2 versions published): https://docusaurus.io/docs/versioning#link-docs-by-file-paths

  • Should we only do this when we cut 1.8 (and then serve version 1.7 and "lastVersion" 1.8)? Per Docusaurus, we shouldn't version patch releases. Since we will still need to update the docs for regular edits and patch release changes during 1.7, we don't want to "lock" the 1.7 docs yet.

    • Alternatively, should lastVersion be 1.7 and Next be 1.8?

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 23, 2025
@github-actions

This comment has been minimized.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 23, 2025
@github-actions

This comment has been minimized.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@mendonk
Copy link
Collaborator Author

mendonk commented Dec 23, 2025

@aimurphy

  1. The actual version switcher is now added, i forgot it :-)
  2. The slugs seem to be working in a test run of 1.8 locally.
  3. Updated versions to display as .x for the patch versions.
  4. Updated "next" version to display as 1.8.x.
  5. We can still update 1.7.x as needed, while 1.8.x is the "main" for the next version.

@mendonk mendonk requested a review from aimurphy December 23, 2025 17:10
@aimurphy
Copy link
Collaborator

@mendonk Can the version switcher be on top of the left sidebar? It gets lost by the social icons.

items: [
{
type: 'docsVersionDropdown',
position: 'right',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
position: 'right',
position: 'left',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants