Skip to content

Conversation

@Cristhianzl
Copy link
Member

This pull request contains a version bump and dependency updates for both the backend and frontend, as well as significant refactoring and cleanup of file upload and file input components in the frontend. The changes improve modularity, enable easier customization, and fix path handling for file storage. Below are the most important changes, grouped by theme.

Frontend Refactoring and Customization:

  • Refactored file input handling to use a new customUsePostUploadFile hook, replacing direct imports of usePostUploadFile in InputFileComponent and IOFileInput for improved customization and separation of concerns. (src/frontend/src/components/core/parameterRenderComponent/components/inputFileComponent/index.tsx, src/frontend/src/modals/IOModal/components/IOFieldView/components/file-input.tsx, src/frontend/src/customization/hooks/use-custom-upload-file-v1.ts, [1] [2] [3] [4]
  • Removed unused or redundant customization wrapper components (custom-input-file, custom-chat-input, custom-file-card, custom-file-input, custom-use-file-handler) to simplify the codebase and reduce maintenance overhead. (src/frontend/src/customization/components/custom-input-file.tsx, src/frontend/src/customization/components/custom-chat-input.tsx, src/frontend/src/customization/components/custom-file-card.tsx, src/frontend/src/customization/components/custom-file-input.tsx, src/frontend/src/customization/hooks/use-custom-use-file-handler.ts, [1] [2] [3] [4] [5]
  • Updated ParameterRenderComponent to use the standard InputFileComponent directly instead of a custom wrapper, aligning with the new refactoring. [1] [2]
  • Added a new CustomAuthenticatedImage component for customizable authenticated image rendering.

Backend Improvements:

  • Improved the parse_file_path method in LocalStorage to use pathlib.Path for robust, cross-platform file path handling, making file storage more reliable and Windows-compatible. [1] [2]

Dependency and Version Updates:

  • Bumped backend and frontend package versions (langflow to 1.7.2, langflow-base to 0.7.2) and updated dependencies (langflow-base, lfx) to their latest compatible versions. [1] [2] [3] [4] [5] [6]
  • Cleaned up package-lock.json by removing some unused dependencies, reflecting the frontend refactoring. [1] [2]

Other Notable Changes:

  • Added a .cursor/DEVELOPMENT_RULE.md file outlining detailed development guidelines, best practices, and code quality standards for the project.
  • Improved authenticated image fetching in IOFileInput by retrieving images as blobs via the API, ensuring proper authentication and error handling.

These changes collectively improve maintainability, modularity, and reliability of file handling and customization throughout the codebase.

@Cristhianzl Cristhianzl self-assigned this Dec 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release-1.7.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Dec 26, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 16%
15.75% (4328/27473) 8.79% (1852/21064) 9.92% (601/6053)

Unit Test Results

Tests Skipped Failures Errors Time
1684 0 💤 0 ❌ 0 🔥 21.645s ⏱️

@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 47.36842% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.27%. Comparing base (6aa9178) to head (b794eec).

Files with missing lines Patch % Lines
src/lfx/src/lfx/services/storage/local.py 9.09% 10 Missing ⚠️
...l/components/IOFieldView/components/file-input.tsx 0.00% 9 Missing ⚠️
...mization/components/custom-authenticated-image.tsx 0.00% 6 Missing ⚠️
...ts/chatView/fileComponent/components/file-card.tsx 0.00% 6 Missing ⚠️
...c/customization/hooks/use-custom-upload-file-v1.ts 0.00% 4 Missing ⚠️
...Modal/components/chatView/components/chat-view.tsx 0.00% 3 Missing ⚠️
...w/fileComponent/components/authenticated-image.tsx 91.66% 0 Missing and 3 partials ⚠️
...rComponent/components/inputFileComponent/index.tsx 0.00% 2 Missing ⚠️
...Modal/components/chatView/chatInput/chat-input.tsx 0.00% 2 Missing ⚠️
...nents/chatView/chatInput/hooks/use-file-handler.ts 0.00% 2 Missing ⚠️
... and 3 more

❌ Your project status has failed because the head coverage (39.97%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-1.7.1   #11151      +/-   ##
=================================================
+ Coverage          33.22%   33.27%   +0.05%     
=================================================
  Files               1370     1368       -2     
  Lines              64073    64096      +23     
  Branches            9418     9424       +6     
=================================================
+ Hits               21287    21329      +42     
+ Misses             41735    41714      -21     
- Partials            1051     1053       +2     
Flag Coverage Δ
backend 53.24% <100.00%> (+0.01%) ⬆️
frontend 14.57% <45.20%> (+0.12%) ⬆️
lfx 39.97% <9.09%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/backend/base/langflow/services/storage/local.py 87.75% <100.00%> (+0.52%) ⬆️
...s/IOModal/components/IOFieldView/io-field-view.tsx 0.00% <ø> (ø)
...components/core/parameterRenderComponent/index.tsx 0.00% <0.00%> (ø)
...tView/chatMessage/components/file-card-wrapper.tsx 0.00% <0.00%> (ø)
.../chatView/fileComponent/utils/format-file-name.tsx 0.00% <0.00%> (ø)
...rComponent/components/inputFileComponent/index.tsx 0.00% <0.00%> (ø)
...Modal/components/chatView/chatInput/chat-input.tsx 0.00% <0.00%> (ø)
...nents/chatView/chatInput/hooks/use-file-handler.ts 0.00% <0.00%> (ø)
...Modal/components/chatView/components/chat-view.tsx 0.00% <0.00%> (ø)
...w/fileComponent/components/authenticated-image.tsx 91.66% <91.66%> (ø)
... and 5 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Dec 26, 2025
@Cristhianzl Cristhianzl deleted the release-1.7.2 branch December 26, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Maintenance tasks and housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants