fix(kb): Ingest Content rename, ingest-open-by-default, deprecated badge for Google/IBM embeddings#12915
Open
keval718 wants to merge 3 commits intorelease-1.10.0from
Open
fix(kb): Ingest Content rename, ingest-open-by-default, deprecated badge for Google/IBM embeddings#12915keval718 wants to merge 3 commits intorelease-1.10.0from
keval718 wants to merge 3 commits intorelease-1.10.0from
Conversation
…ault Rename "Configure Sources" heading to "Ingest Content" and the dropdown trigger from "Add Sources" to "Add Files". Drop the "Hide Configuration" footer toggle so the ingest section is always visible. Chunk size, overlap, and separator inputs render disabled until at least one source is added. Match the Add Files focus-visible ring to border-input so the Radix-managed focus return no longer flashes a black outline.
Flag the Google Generative AI and IBM WatsonX embedding model entries in the unified model catalog as deprecated. They are not natively supported by Knowledge Base ingestion, so users were attempting invalid configurations. The KB upload picker and Model Providers modal now fetch with include_deprecated=true and render a "Deprecated" badge so the models stay visible but are clearly flagged as unsupported.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
bug
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #12915 +/- ##
==================================================
+ Coverage 53.82% 53.89% +0.07%
==================================================
Files 2045 2045
Lines 185870 185946 +76
Branches 27938 27938
==================================================
+ Hits 100041 100223 +182
+ Misses 84728 84613 -115
- Partials 1101 1110 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-actions
Bot
added
bug
Only mark text-embedding-004 and embedding-001 as deprecated; the gemini-embedding-001 model is still served by the Google Generative AI v1beta endpoint, so leave it visible without the badge.
github-actions
Bot
added
bug
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the Knowledge Base upload UX and surfaces unsupported embedding models without misleading users.
focus-visiblering toborder-inputso the Radix-managed focus return no longer flashes a black outline after the menu closes.deprecated=Truein the unified model catalog. They are not natively supported by KB ingestion, so users were attempting invalid configurations.ModelList) and Model Providers modal (ModelSelection) now fetch withinclude_deprecated=trueand render a Deprecated badge so the models stay visible but are clearly marked as unsupported.Anthropic still has no embedding models — they don't ship an embedding API.
Fixes #12277
Files touched
src/lfx/src/lfx/base/models/google_generative_ai_constants.pysrc/lfx/src/lfx/base/models/watsonx_constants.pysrc/frontend/src/modals/knowledgeBaseUploadModal/**src/frontend/src/modals/modelProviderModal/components/{ModelSelection,ProviderList}.tsxsrc/frontend/src/modals/modelProviderModal/hooks/useProviderConfiguration.tssrc/frontend/src/components/core/parameterRenderComponent/components/modelInputComponent/components/ModelList.tsxTest plan
npx jest src/components/core/parameterRenderComponent/components/modelInputComponent src/modals/modelProviderModal src/modals/knowledgeBaseUploadModal— 144/144 pass/api/v1/models?include_deprecated=true&model_type=embeddingsreturns Google + IBM entries withmetadata.deprecated == true