fix: route custom Loguru logs through Langflow logger#12926
Open
erichare wants to merge 1 commit intorelease-1.10.0from
Open
fix: route custom Loguru logs through Langflow logger#12926erichare wants to merge 1 commit intorelease-1.10.0from
erichare wants to merge 1 commit intorelease-1.10.0from
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12805.
Custom components that import
loggerdirectly from Loguru were bypassing Langflow's configured logging pipeline. As a result, messages such aslogger.info(f"Processing {file_path}")could appear on stderr but not in the configuredLANGFLOW_LOG_FILE, even whenLANGFLOW_LOG_LEVEL=DEBUGand log retrieval/file logging were enabled.This PR routes Loguru's default logger through Langflow's structlog configuration so those custom component messages reach the same sinks as the rest of Langflow logging. It also keeps repeated
configure(...)calls from stacking duplicate rotating file handlers.Root Cause
configure()configured Langflow's structlog logger and stdlib file handlers, but plainfrom loguru import loggerusage kept Loguru's default sink. Custom component logs emitted through Loguru therefore skipped Langflow's configured file handler.Changes
Validation
uv run ruff check src/lfx/src/lfx/log/logger.py src/backend/tests/unit/test_logger.pyuv run pytest src/backend/tests/unit/test_logger.pyloguru.logger.info("Processing /tmp/example.png")lands inLANGFLOW_LOG_FILE.