fix: MCP connection refresh state#12931
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.10.0 #12931 +/- ##
==================================================
- Coverage 53.87% 53.72% -0.16%
==================================================
Files 2051 2051
Lines 187230 187356 +126
Branches 26578 26668 +90
==================================================
- Hits 100863 100648 -215
- Misses 85256 85598 +342
+ Partials 1111 1110 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
e741cdd to
7c2e84e
Compare
Summary
Root Cause
MCP server/tool refreshes could reuse existing dropdown options or cache entries, so a node that had previously failed could keep stale frontend error state even after the backend had successfully refreshed the server configuration. Error placeholders also collapsed connection failures into generic text.
Validation
uv run pytest src/backend/tests/unit/components/models_and_agents/test_mcp_component_dynamic.py -qnpm test -- McpComponent.test.tsx --runInBandnpm run lint:types -- src/components/core/parameterRenderComponent/components/mcpComponent/index.tsx src/components/core/parameterRenderComponent/components/mcpComponent/__tests__/McpComponent.test.tsxuv run ruff format src/lfx/src/lfx/components/models_and_agents/mcp_component.py src/backend/tests/unit/components/models_and_agents/test_mcp_component_dynamic.py --checkuv run git commit