-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate Parsing component and replace them in starter projects #6697
base: fix/parser_component
Are you sure you want to change the base?
feat: deprecate Parsing component and replace them in starter projects #6697
Conversation
CodSpeed Performance ReportMerging #6697 will improve performances by 57.1%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better if we switch the legacy components for the new components in the starter projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
On testing found a bug in new parser component: data_to_text : test portfolio website generator. |
@Cristhianzl @erichare @mendonk Looking forward to your support for review. |
…egacy switch functionality ✨ (similarity.spec.ts): add new test steps to check sidebar options and legacy switch functionality ✨ (loop-component.spec.ts): add new test steps to check sidebar options and legacy switch functionality, as well as zoom out and expand button modal functionality
… Generator.spec.ts, decisionFlow.spec.ts, similarity.spec.ts, generalBugs-shard-9.spec.ts, codeAreaModalComponent.spec.ts, fileUploadComponent.spec.ts, nestedComponent.spec.ts, filterEdge-shard-1.spec.ts, loop-component.spec.ts, generalBugs-shard-12.spec.ts, add-legacy-components.ts): add function to handle legacy components in tests for improved test readability and maintainability
50f9690
to
b702139
Compare
Do not Merge until. |
This pull request includes changes to mark certain components as legacy and format JSON files for better readability. The most important changes include setting the
legacy
attribute toTrue
for specific components and formatting theBlog Writer.json
file.Marking components as legacy:
src/backend/base/langflow/components/processing/parse_data.py
: Addedlegacy = True
to theParseDataComponent
class.src/backend/base/langflow/components/processing/parse_dataframe.py
: Addedlegacy = True
to theParseDataFrameComponent
class.Formatting JSON files:
src/backend/base/langflow/initial_setup/starter_projects/Blog Writer.json
: Reformatted the JSON structure to use arrays foroutput_types
,inputTypes
,field_order
, and other fields for better readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22]