Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Parsing component and replace them in starter projects #6697

Open
wants to merge 14 commits into
base: fix/parser_component
Choose a base branch
from

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes changes to mark certain components as legacy and format JSON files for better readability. The most important changes include setting the legacy attribute to True for specific components and formatting the Blog Writer.json file.

Marking components as legacy:

Formatting JSON files:

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 18, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

To be merged after:
#6642 #6652
#6302

Templates to b updated once these PRs are Merged.

Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #6697 will improve performances by 57.1%

Comparing deprecate-parsing-components (10d4a27) with main (e82b23f)

Summary

⚡ 2 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 12.4 ms 7.9 ms +56.56%
test_cancel_nonexistent_build 12.2 ms 7.7 ms +57.1%

Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better if we switch the legacy components for the new components in the starter projects

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2025
@carlosrcoelho carlosrcoelho requested review from lucaseduoli and removed request for lucaseduoli March 5, 2025 13:47
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 25, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

On testing found a bug in new parser component:

data_to_text : test portfolio website generator.

@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl @erichare @mendonk
Few of templates are getting updated here since a new parser component is being used instead of deprecated ones.

Looking forward to your support for review.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 26, 2025
@edwinjosechittilappilly edwinjosechittilappilly added the DO NOT MERGE Don't Merge this PR label Mar 26, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 26, 2025
edwinjosechittilappilly and others added 13 commits March 27, 2025 18:59
…egacy switch functionality

✨ (similarity.spec.ts): add new test steps to check sidebar options and legacy switch functionality
✨ (loop-component.spec.ts): add new test steps to check sidebar options and legacy switch functionality, as well as zoom out and expand button modal functionality
… Generator.spec.ts, decisionFlow.spec.ts, similarity.spec.ts, generalBugs-shard-9.spec.ts, codeAreaModalComponent.spec.ts, fileUploadComponent.spec.ts, nestedComponent.spec.ts, filterEdge-shard-1.spec.ts, loop-component.spec.ts, generalBugs-shard-12.spec.ts, add-legacy-components.ts): add function to handle legacy components in tests for improved test readability and maintainability
@edwinjosechittilappilly edwinjosechittilappilly changed the base branch from main to fix/parser_component March 27, 2025 23:01
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 27, 2025
@edwinjosechittilappilly edwinjosechittilappilly force-pushed the deprecate-parsing-components branch from 50f9690 to b702139 Compare March 27, 2025 23:02
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 27, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

Do not Merge until.
#7303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't Merge this PR enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants